Closed
Bug 1109235
Opened 10 years ago
Closed 9 years ago
remove nsIStreamCipher and implementation
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: keeler, Assigned: retornam, Mentored)
Details
(Whiteboard: [good first bug] )
Attachments
(1 file, 1 obsolete file)
|
14.48 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
nsIStreamCipher doesn't appear to be used. We can remove it, if so.
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [good first bug][mentor=keeler]
|
|
||
Comment 1•10 years ago
|
||
Have you checked extensions?
|
|
Reporter | |
Comment 2•10 years ago
|
||
I did find one extension that uses it, but it's only compatible with Firefox version <= 12, so I think it's safe to remove.
|
||
Updated•10 years ago
|
Mentor: dkeeler
Whiteboard: [good first bug][mentor=keeler] → [good first bug]
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mozbugs.retornam
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8535665 -
Flags: review?(dkeeler)
|
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8535665 [details] [diff] [review] bug-1109235.patch Review of attachment 8535665 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! However, there are a couple more things to remove. For instance, anything that references nsStreamCipher in nsNSSModule: http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#34 http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#198 http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#231 http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#263 http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#300 Also this: http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/moz.build#61 r- for now.
Attachment #8535665 -
Flags: review?(dkeeler) → review-
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8535665 -
Attachment is obsolete: true
Attachment #8541807 -
Flags: review?(dkeeler)
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8541807 [details] [diff] [review] bug-1109235.patch Review of attachment 8541807 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8541807 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug]
|
||
Comment 7•9 years ago
|
||
Hi, can we get a try run for this changes? Thanks!
Flags: needinfo?(mozbugs.retornam)
Keywords: checkin-needed
|
|
Reporter | |
Comment 8•9 years ago
|
||
I went ahead and ran this through try and checked it in. Due to bug 1114669, I also touched CLOBBER to be safe. https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef7c77fc900 https://hg.mozilla.org/integration/mozilla-inbound/rev/f4ddeae5b6c4
Flags: needinfo?(mozbugs.retornam)
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f4ddeae5b6c4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•