Closed
Bug 1109240
Opened 10 years ago
Closed 10 years ago
[Camera] Remove unsolicited event callbacks from Camera app
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikeh, Assigned: mikeh)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8533933 -
Flags: review?(jdarcangelo)
Comment 2•10 years ago
|
||
Comment on attachment 8533933 [details] [review] pull-request (master) LGTM
Attachment #8533933 -
Flags: review?(jdarcangelo) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/2839fecb02a3f17d0306c4f6fcc894b93791e311
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
Reverted for busting camera app as per Wilson's comment here: https://bugzilla.mozilla.org/show_bug.cgi?id=1109573#c2 https://github.com/mozilla-b2g/gaia/commit/37819febbe4d700f34377ba04bc680c973079dd2 Switch the ni? to this bug to de-dupe the bugs.
Status: RESOLVED → REOPENED
Flags: needinfo?(mhabicher)
Resolution: FIXED → ---
Assignee | ||
Comment 5•10 years ago
|
||
I just reapplied the patch in bug 1109240 to a fresh pull/build of my gecko and gaia trees, and the Camera app works as expected, including face detection. Gonk v188-1 Gecko b2g-inbound/219028:a6282dfb2764 Gaia master/e04ab7651b1e0c67516e1cef7aa4bc6072529885
Flags: needinfo?(mhabicher)
Assignee | ||
Comment 6•10 years ago
|
||
Okay, the problem only seems to happen when *re*opening the camera. STR: 1. open Camera app 2. press Home button 3. reopen Camera app Observed: spinner. Expected: active viewfinder.
Assignee | ||
Comment 7•10 years ago
|
||
Wilson, is this the error you were seeing in bug 1109573? [JavaScript Error: "TypeError: faces is undefined" {file: "app://camera.gaiamobile.org/js/main.js" line: 10809}]
Flags: needinfo?(wilsonpage)
Assignee | ||
Comment 8•10 years ago
|
||
Fix bustage in bug 1109573. The difference is: 1. https://github.com/mozilla-b2g/gaia/pull/26699/files#diff-b2ec18150f47bf7f826e5cbc8c49fddeR88 2. https://github.com/mozilla-b2g/gaia/pull/26699/files#diff-b2ec18150f47bf7f826e5cbc8c49fddeR105
Attachment #8533933 -
Attachment is obsolete: true
Attachment #8534533 -
Flags: review?(jdarcangelo)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(wilsonpage)
Updated•10 years ago
|
Attachment #8534533 -
Flags: review?(jdarcangelo) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/35ae5aeac71b5790399c5104442692664d649432 (Take 2.)
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
(In reply to Mike Habicher [:mikeh] from comment #7) > Wilson, is this the error you were seeing in bug 1109573? > > [JavaScript Error: "TypeError: faces is undefined" {file: > "app://camera.gaiamobile.org/js/main.js" line: 10809}] Yeah, that's the one.
You need to log in
before you can comment on or make changes to this bug.
Description
•