1109299 - Hide admin-flagged and blocked add-ons from editors without privileges to review them

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Kris Maglione [:kmag]]

By default, the queues should only show admin-flagged add-ons to editors who are eligible to review them. We should also add a flagged for reviews which are blocked on arbitrary decisions or replies. It should be possible for anyone to view these items, but they should only be shown to privileged reviewers by default.

The idea behind this is to make add-ons with longer wait times more attractive to review, and to decrease unnecessary and often confusing clutter.

Comment 1

[Kris Maglione [:kmag]]

I'm splitting off the marking of blocked add-ons into a separate bug. This currently only applies to changing of default filters to match reviewers' privilege levels.

Comment 2

[Kris Maglione [:kmag]]

Updated requirements:

By default, unprivileged reviewers should not see add-ons with any of the following flags in their queues:

• Needinfo
• Admin
• Blocked (to be added in bug 1112372)

Comment 3

[Rob Hudson [:robhudson]]

I started to implement this but I will have to set it aside for now.

Some notes:
* A privileged reviewer can be determined by:

    acl.action_allowed(request, 'ReviewerAdminTools', 'View') == True

* You should be able to filter out the addons in the queue via:

    qs = qs.filter(admin_review=False, has_info_request=False)

* We also need to update the queue counts code, however, this code currently does not have access to the request so some refactoring is required. This is where I ran out of time.

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/olympia/pull/705

Comment 5

[Andreas Wagner [:TheOne] [use NI]]

To make this actually useful, we need a followup bug which defines what developer action(s) should clear the "need info" flag, because afaik currently only a new version submission clears it, which is not enough.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/996f8a9c1e698d499950063e57625ad5a69e3fae
Hide unreviewable addons from editor tools (bug 1109299)

Fixes #705

Comment 7

[Mark Striemer [:mstriemer]]

This just hides admin flagged add-ons for now. We can hide the need info add-ons when that flag is removed more aggressively.