1109895 - Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[(no longer active)]

Attachment: Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8534626 [details] [diff] [review]
Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel

Review of attachment 8534626 [details] [diff] [review]:
-----------------------------------------------------------------

Why doesn't

::: media/libvpx/moz.build
@@ +91,5 @@
>          SOURCES += [
>              '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'],
>          ]
>  
> +if not CONFIG['_MSC_VER'] or CONFIG['CLANG_CL']:

I would find this easier to read if you reversed the condition. i.e. 

if CONFIG['CLANG_CL'] or not CONFIG['_MSC_VER']

This removes ambiguity of the not.

Comment 3

[(no longer active)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Why doesn't

?

> ::: media/libvpx/moz.build
> @@ +91,5 @@
> >          SOURCES += [
> >              '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'],
> >          ]
> >  
> > +if not CONFIG['_MSC_VER'] or CONFIG['CLANG_CL']:
> 
> I would find this easier to read if you reversed the condition. i.e. 
> 
> if CONFIG['CLANG_CL'] or not CONFIG['_MSC_VER']
> 
> This removes ambiguity of the not.

OK, will do.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ad46fb370ea