1110144 - (serviceworker-cache) ship Service Worker Cache in release builds

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

This is a meta bug for all SW Cache work that must be done before the feature can be pref'd on.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I guess its more typical to just make a "pref it on" bug instead of a meta bug here.  Lets do that.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Shipping Cache API
[Suggested wording]: Implemented Cache API for querying named caches that are accessible by a ServiceWorker
[Links (documentation, blog post, etc)]:
Standard:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-objects
MDN docs: https://developer.mozilla.org/en-US/docs/Web/API/CacheStorage

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Enable Cache API in release builds. r=ehsan

Comment 4

[(no longer active)]

Comment on attachment 8626870 [details] [diff] [review]
Enable Cache API in release builds. r=ehsan

Review of attachment 8626870 [details] [diff] [review]:
-----------------------------------------------------------------

Congrats!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f71f5a88e16d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f71f5a88e16d

Comment 7

[Andrew Overholt [:overholt]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #2)
> Release Note Request (optional, but appreciated)
> [Why is this notable]: Shipping Cache API
> [Suggested wording]: Implemented Cache API for querying named caches that
> are accessible by a ServiceWorker

Caches are accessible by non-Service Workers, too.  Ben, what do you think this should read?

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

I guess it could changed to:

  "Implemented Cache API for querying named caches that are accessible from window, Worker, and ServiceWorker."

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Release note added to Firefox 41.0a2

Comment 10

[Chris Mills [:cmills]]

I've updated browser compat information in the relevant articles:

https://developer.mozilla.org/en-US/docs/Web/API/CacheStorage (and member subpages)
https://developer.mozilla.org/en-US/docs/Web/API/Cache (and member subpages)

And added a note about it being exposed to window as well as worker.

I've also added a note here:

https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers

Comment 11

[Matt Falkenhagen]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> I've also added a note here:
> 
> https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers

Just a note, the way that's written looks like Cache is behind the "experimental Service Worker implementation", and not totally clear it's actually shipping. Maybe it should be moved outside that bulleted list?

Comment 12

[Chris Mills [:cmills]]

(In reply to Matt Falkenhagen from comment #11)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> > I've also added a note here:
> > 
> > https://developer.mozilla.org/en-US/Firefox/Releases/41#Service_Workers
> 
> Just a note, the way that's written looks like Cache is behind the
> "experimental Service Worker implementation", and not totally clear it's
> actually shipping. Maybe it should be moved outside that bulleted list?

I think you've got a good point here. I've updated it as requested.