Note: There are a few cases of duplicates in user autocompletion which are being worked on.
Last Comment Bug 1110215 - Run an experiment: disable Flash protected mode and see how that affects the plugin crash/hang and BHR data
: Run an experiment: disable Flash protected mode and see how that affects the ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: unspecified
: x86 Windows 7
-- normal (vote)
: ---
Assigned To: Benjamin Smedberg [:bsmedberg]
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on: 1108035 1110818 1111791 1112677
Blocks:
  Show dependency treegraph
 
Reported: 2014-12-11 08:35 PST by Benjamin Smedberg [:bsmedberg]
Modified: 2015-01-23 06:38 PST (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
flash-protected (4.18 KB, patch)
2014-12-15 15:25 PST, Benjamin Smedberg [:bsmedberg]
felipc: review+
Details | Diff | Splinter Review

Description User image Benjamin Smedberg [:bsmedberg] 2014-12-11 08:35:49 PST
On Windows 7+, we'd like to run an experiment on beta to force-disable Flash protected mode and see how that affects the Flash crash/hang rates.

To reduce data latency, I'm going to see if we can record all the necessary data in the telemetry payload instead of relying on FHR.
Comment 1 User image Benjamin Smedberg [:bsmedberg] 2014-12-15 15:25:50 PST
Created attachment 8536855 [details] [diff] [review]
flash-protected
Comment 2 User image :Felipe Gomes (needinfo me!) 2014-12-15 15:39:47 PST
Comment on attachment 8536855 [details] [diff] [review]
flash-protected

Review of attachment 8536855 [details] [diff] [review]:
-----------------------------------------------------------------

::: experiments/flash-protectedmode-beta/code/bootstrap.js
@@ +11,5 @@
> +function startup() {
> +  // Seems startup() function is launched twice after install, we're
> +  // unsure why so far. We only want it to run once.
> +  if (gStarted) {
> +    Cu.reportError("startup() function was launched twice; making second run return.");

this is an artifact of the way that experiments are installed/started up by being disabled by default and then getting enabled. I meant to file a bug about it last time but I think I never did.

Which is to say this is a known thing, no need to Cu.reportError. But yeah, keep the `if (gStarted) { return; }`.

@@ +45,5 @@
> +    });
> +}
> +
> +function shutdown() {
> +  gStarted = false;

Probably no point in setting this to false, unless you want to properly support hot-disabling the experiment and having it undo its effect. But in that case you will also need to clear the pref that was set.
Comment 3 User image Benjamin Smedberg [:bsmedberg] 2014-12-15 16:03:31 PST
Staged: https://hg.mozilla.org/webtools/telemetry-experiment-server/rev/5448d3fa18f0

QA instructions:

Test using FF35.0b4 which should be built today.
Change these prefs:
* experiments.manifest.cert.checkAttributes;false
* experiments.manifest.uri replace telemetry-experiment.cdn.mozilla.net with telemetry-experiment-dev.allizom.org
* Use https://wiki.mozilla.org/QA/Telemetry/BrowserConsoleCommands to force-refresh the experiments
* Run the following command to see what experiment branch you are in: Experiments.instance()._getActiveExperiment.branch
** if you are in the "control" group, the pref dom.ipc.plugins.flash.disable-protected-mode should be false
** if you are in the "experiment" group, the pref should be true
The branch should be random 50/50 split. If you want to re-test to try and get into the other branch, close Firefox and delete <profile>/experiments.json and relaunch/force-refresh
Comment 4 User image Benjamin Smedberg [:bsmedberg] 2014-12-17 13:42:28 PST
Deployed in bug 1112677

Note You need to log in before you can comment on or make changes to this bug.