1110455 - Add --sort-by=block-counts option to dmd.py

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Nicholas Nethercote [inactive]]

ehoogeveen suggested this. It only makes sense when used with --sample-below=1, so maybe it should give a warning if you use it without that.

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Technically I guess if a small allocation shows up so often that even with the sampling it's one of the top entries, that's more reason to look into it :)

I was thinking that it could use cmpByUsableSize [1] on a tie, though for large block counts a tie might not be very likely.

[1] http://dxr.mozilla.org/mozilla-central/source/memory/replace/dmd/dmd.py?from=dmd.py#134

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Add --sort-by=num-blocks option to dmd.py

This required tweaking the "sort-by" tests a little.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/314802d1887c