1111086 - "Thanks for signing up!" newsletter footer persists when navigating to another page

Status: RESOLVED INCOMPLETE

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: screenshot of "Thanks for signing up!" in newsletter footer

1. Load https://marketplace-dev.allizom.org/ on desktop.
2. Scroll to the bottom and sign up for the newsletter.
3. Notice the "Thanks for signing up!" message appears.
4. Navigate to like another page (e.g., Popular page or an app detail page).
5. Notice the "Thanks for signing up!" message still appears.
6. Refresh the page in your browser.
7. Notice the original newsletter form is shown.

Comment 1

[Mathieu Pillard [:mat]]

Ah, yeah, since it's in the footer... We could hide the newsletter part of the footer when the user navigates away, if it was successful.

Comment 2

[David Durst [:ddurst]]

+1 to what mat said, and preserve that for the session.

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/pull/857

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/cd1e8b423099f9564ac3561a84bd066520d4bac3

Comment 5

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/ on FF 37 (Win 7).
Postfix screencast http://screencast.com/t/LBsNfBrpmoCm
Closing bug.

Comment 6

[Mark Striemer [:mstriemer]]

This unfortunately made it to production earlier than anticipated. We're going to hold off on making a change like this until we get a spec from UX.

Reverted in https://github.com/mozilla/fireplace/commit/a03f7c4687299acd718810c8e2faeb939a763a19