111126 - [RFE] Add print preview menu command to the nav bar.

Status: VERIFIED FIXED

(Core :: Printing: Output, enhancement)

Description

[brian]

Add the print preview menu command to the drop down print button list in the
navigation bar.

Comment 1

[Boris Zbarsky [:bzbarsky]]

over to rods, who's doing print preview

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Taking this bug

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Suggested Patch

This should fix the bug. bz, could you review?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 58722 [details] [diff] [review]
Suggested Patch

r=bzbarsky

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I was told that the print dropdown menu will be removed soon, but not in
commercial builds, and that I should not waste my time with this bug.

So, reassigning to default owner to decide whether to get sr and check this in
or only checking it into commercial tree.

Comment 6

[Jesse Ruderman]

Since bug 63042 (remove the menu) is futured, I don't see why this fix should 
be commercial-only.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 113604 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Jesse's right.  We have many things that are "soon to be removed" (eg non-XBL
form controls).  It's not happening any time soon, and neither is bug 63042.

biesi, you should just ask blake for sr

Comment 9

[Blake Ross]

Comment on attachment 58722 [details] [diff] [review]
Suggested Patch

sr=blake

Comment 10

[Boris Zbarsky [:bzbarsky]]

Checked in.  Thanks for doing this, biesi!

Comment 11

[sujay]

this is still not fixed in 12/13 build...I only see "Print" when clicking
on the Print icon to see the drop down menu.

Comment 12

[Boris Zbarsky [:bzbarsky]]

sujay, is this a mozilla or commercial build?  Also, this is trunk, right?

Comment 13

[sujay]

yes, commercial trunk...12/13 build on win.

I definitely don't see the Print Preview in the pull-down print icon.

Comment 14

[Boris Zbarsky [:bzbarsky]]

This worksforme on mozilla builds.  Sounds like a commercial-only problem. 
Perhaps commercial has a separate XUL file here?

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

sujay: What about filing a Bugscape bug for this, in Mozilla this is obviously
working.

Comment 16

[sujay]

ok I see it now in 12/18 commercial trunk build.

Comment 17

[sujay]

verified.

Comment 18

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.