1112088 - Use Downloads.jsm functions to get download directories in the Safari Migrator

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[:Paolo Amadini]

Attachment: Untested patch

This is part of bug 875648.

I've not added a wrapper for the outer Task, similar to the one for the synchronous function, because there is only one instance for now.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8537206 [details] [diff] [review]
Untested patch

Review of attachment 8537206 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good.
Unfortunately we don't have automated tests covering this, do you have the opportunity to test this manually?

Ideally, we could even write a mac-only xpcshell-test checking it, but it would require to also set the downloads folder (DownloadsPath) in the system plist, and we only have a plist reader, not a writer.

Comment 2

[:Paolo Amadini]

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1)
> Unfortunately we don't have automated tests covering this, do you have the
> opportunity to test this manually?

I tested this right now, setting the preference to the Desktop, Downloads, and a custom folder.

There was an import missing but the rest worked just fine. Landed on fx-team:

https://hg.mozilla.org/integration/fx-team/rev/38471b0310c9

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/38471b0310c9

Comment 4

[:Paolo Amadini]

This can be tested by changing the default download location in Safari and importing preferences from Safari (<https://support.mozilla.org/en-US/kb/import-bookmarks-data-another-browser>).

Comment 5

[Catalin Varga [QA][:VarCat]]

Can this be tested manually? If yes, can you please provide a more detailed scenario?

Comment 6

[:Paolo Amadini]

(In reply to Catalin Varga [QA][:VarCat] from comment #5)
> Can this be tested manually? If yes, can you please provide a more detailed
> scenario?

Yes, firstly you should open Safari and change the download location from its preferences window.

There are three cases to test:
- Desktop folder
- Downloads folder
- Custom folder

For each of these, you should save the setting in Safari, then switch to Firefox and go through the wizard that allows you to import those settings:

https://support.mozilla.org/en-US/kb/import-bookmarks-data-another-browser

You should verify that the corresponding download location in the Firefox preferences has been updated correctly.

Hope this helps!

Comment 7

[Catalin Varga [QA][:VarCat]]

Thanks for the prompt feedback.

Verified the fix using the following environment:

FF 37 Developer Edition
Build Id:20150212004049
OS: Mac Os X 10.9.5, Win 7 x64

the corresponding download location in Firefox preferences is successfully updated after each import of data from Safari.

Comment 8

[:Paolo Amadini]

(In reply to Catalin Varga [QA][:VarCat] from comment #7)
> OS: Mac Os X 10.9.5, Win 7 x64

Thanks for testing on Windows too!