1112112 - Add logging for e10s parent-child channels

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Dragana Damjanovic [:dragana]]

Additional logging for e10s channels

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: added logging v1

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: add logging v1

Comment 3

[Jason Duell]

Comment on attachment 8537960 [details] [diff] [review]
add logging v1

Review of attachment 8537960 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/HttpChannelChild.cpp
@@ +216,5 @@
>    {}
>  
>    void Run()
>    {
> +    LOG(("StartRequestEvent [this=%x]\n", mChild));

mChild is a pointer, so we need %x (IIRC %x is only 32 bits on some platforms that have 64 bit pointers: I'm pretty sure we had a bug where we converted %x -> %p everywhere for that reason).

@@ +643,5 @@
>  void
>  HttpChannelChild::DoPreOnStopRequest(nsresult aStatus)
>  {
> +  LOG(("HttpChannelChild::DoPreOnStopRequest [this=%p status=%d]\n",
> +       this, aStatus));

nsresults are uint32_t.  This patch has a mix of %x, %u, and %d for them.  %d would appear incorrect (though I don't know if it matters, ie if we have values that would be converted to negative ints).  Might as well switch to whichever of %x/%u is more predominant in the code.

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: add logging v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3d251b5f206

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 6

[Dragana Damjanovic [:dragana]]

Attachment: add logging v2

rebased

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00fc776b6f55

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00fc776b6f55