1112189 - Telemetry for tracking protection shield

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Histograms already exist for measuring tracking protection events in desktop, we should just add the probes in the right place for Fennec.

  "TRACKING_PROTECTION_ENABLED": {
    "expires_in_version": "never",
    "kind": "boolean",
    "description": "Whether or not a session has tracking protection enabled"
  },
  "TRACKING_PROTECTION_SHIELD": {
    "expires_in_version": "never",
    "kind": "enumerated",
    "n_values": 4,
    "description": "Tracking protection shield (0 = not shown, 1 = blocked, 2 = loaded, 3 = due to mixed content"
  },
  "TRACKING_PROTECTION_EVENTS": {
    "expires_in_version": "never",
    "kind": "enumerated",
    "n_values": 3,
    "description": "Doorhanger shown = 0, Disable = 1, Enable = 2"
  },

Comment 1

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #0)
> Histograms already exist for measuring tracking protection events in
> desktop, we should just add the probes in the right place for Fennec.
> 
>   "TRACKING_PROTECTION_ENABLED": {
>     "expires_in_version": "never",
>     "kind": "boolean",
>     "description": "Whether or not a session has tracking protection enabled"
>   },

This is slightly redundant with our settings telemetry to tell us when users have enabled this. However, this would be useful for giving us an overview of what percentage of users actually have this enabled, so I think we should add it.

>   "TRACKING_PROTECTION_SHIELD": {
>     "expires_in_version": "never",
>     "kind": "enumerated",
>     "n_values": 4,
>     "description": "Tracking protection shield (0 = not shown, 1 = blocked,
> 2 = loaded, 3 = due to mixed content"
>   },

Our logic is different from desktop here in that we keep the tracking/mixed modes separate until our final decision about what icon to show in the urlbar, so I'm not sure whether we need to record the "due to mixed content" case. If we do, I think we would need to alter our logic to be able to actually record this information.

>   "TRACKING_PROTECTION_EVENTS": {
>     "expires_in_version": "never",
>     "kind": "enumerated",
>     "n_values": 3,
>     "description": "Doorhanger shown = 0, Disable = 1, Enable = 2"
>   },

We already do this, no changes needed.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1112189/margaret

Comment 3

[:Margaret Leibovic]

/r/1571 - Bug 1112189 - Additional telemetry for tracking protection shield. r=mfinkle

Pull down this commit:

hg pull review -r b0390757dbeacf4560f8e21d6c781f034f554bad

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/1569/#review961

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/75e9894b3028

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75e9894b3028

Comment 8

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1112189 - Additional telemetry for tracking protection shield. r=mfinkle