Closed Bug 1112318 Opened 10 years ago Closed 9 years ago

fxpay: make XHR tests more readable

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P5)

Product:
Marketplace Graveyard
Component:
Payments/Refunds
Version:
Avenir
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kumar, Assigned: kumar)

Details

(Whiteboard: [qa-]) 

there are many fxpay tests that do twisted async mocking so that XHR requests result in the right responses. These are hard to read and very fragile since responses can arrive out of order. Let's fix this by introducing some kind of facade object that can be mocked directly without involving XHR.
Assignee: nobody → kumar.mcmillan
Whiteboard: [qa-]
Priority: -- → P5
This is mostly done. I'm following a pattern like this: https://github.com/mozilla/fxpay/pull/96/files#diff-bb3f5158ace8ee2d80b4bc16a174f16aR200 It hides all the XHR mocking so that you only have to change it in one place. Hide the complexity and it goes away!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.