Closed
Bug 1112483
Opened 9 years ago
Closed 9 years ago
display list dump should print the layer offset
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 1 obsolete file)
2.34 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8537657 -
Flags: review?(matt.woodrow)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bgirard
Comment 1•9 years ago
|
||
Comment on attachment 8537657 [details] [diff] [review] patch Review of attachment 8537657 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/nsLayoutDebugger.cpp @@ +149,5 @@ > #endif > bool snap; > nsRect rect = aItem->GetBounds(aBuilder, &snap); > + nsRect layerRect = rect + aItem->ReferenceFrame()->GetOffsetToCrossDoc( > + nsLayoutUtils::GetAnimatedGeometryRootFor(aItem, aBuilder, nullptr)); I think it'd be clearer to do animatedGeometryRoot->GetOffsetToCrossDoc(referenceFrame), and subtract the result instead of adding it.
Attachment #8537657 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8537657 -
Attachment is obsolete: true
Attachment #8538566 -
Flags: review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ddd8f21f0a2
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7ddd8f21f0a2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•