1112517 - Test failure 'Service is no longer marked for uninstall - 'uninstall' should equal '' ' in /testAddons/testServiceInstallDisableEnableRemove.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Module:    testDisableEnableRemoveUndo
Test:      testServiceInstallDisableEnableRemove.js
Failure:   Service is no longer marked for uninstall - 'uninstall' should equal ''
Branches:  Beta (35.0)
Platforms: Mac OS X

Reports:
http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=Mac&from=2014-12-10&to=2014-12-17&test=%2FtestAddons%2FtestServiceInstallDisableEnableRemove.js&func=testDisableEnableRemoveUndo

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The failure message is strange. The reference should be listed as the second part but not the first, and should never be ''.

Comment 2

[Andreea Matei [:AndreeaMatei]]

Daniela, please help us with a skip patch for beta here. Thanks

Comment 3

[Andreea Matei [:AndreeaMatei]]

Seems only OSX is affected here.

Comment 4

[Daniela Domnici]

Attachment: skipServices_V1

I`ve created a skip patch for testServicesInstallDisableEnableRemove.js for MAC

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8539132 [details] [diff] [review]
skipServices_V1

Review of attachment 8539132 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/functional/testAddons/manifest.ini
@@ +9,5 @@
>  [testPluginDisableAffectsAboutPlugins.js]
>  [testPluginInDifferentStates.js]
>  skip-if = os == 'win'
>  [testServiceInstallDisableEnableRemove.js]
> +run-if = os == 'mac'

We want to skip on osx.

Comment 6

[Daniela Domnici]

Attachment: SkipServices_V2

Updated patch

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8539144 [details] [diff] [review]
SkipServices_V2

Review of attachment 8539144 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/ceadc7f1f0ca (beta)

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: skip for all OSes

Comment 9

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8539218 [details] [diff] [review]
skip for all OSes

Review of attachment 8539218 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/2783af9a8beb (beta)

Comment 10

[Cosmin Malutan, [:cosmin-malutan]]

This can be re-enabled, the fix has been landed in bug 1108948.

Comment 11

[Cosmin Malutan, [:cosmin-malutan]]

This was re-enabled on beta due to merge, the skip is now only on release branch, and as it didn't failed with latest beta spin, it's clearly fixed.
http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=All&from=2015-01-20&to=2015-01-21&test=%2FtestAddons%2FtestServiceInstallDisableEnableRemove.js&func=testDisableEnableRemoveUndo

Comment 12

[Andreea Matei [:AndreeaMatei]]

We need a re-enable patch, can't backout on release a changeset from beta.

Comment 13

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: re_enable.patch

Here is the re-enable patch.
Thanks 

Report:
http://mozmill-crowd.blargon7.com/#/functional/report/dd0cbbf05a3aab4a7676502a86b73e27

Comment 14

[Andreea Matei [:AndreeaMatei]]

http://hg.mozilla.org/qa/mozmill-tests/rev/46fee85709d5 (release)
Thanks!

Comment 15

[Cosmin Malutan, [:cosmin-malutan]]

This is still failing, it looks like the dependent bug didn't fixed it. 
One thing I've noticed is that on the dependent bug we didn't had failures on OSX, and on this bug we have only on OSX.

http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=35&platform=Mac&from=2015-01-22&to=2015-01-23&test=%2FtestAddons%2FtestServiceInstallDisableEnableRemove.js&func=testDisableEnableRemoveUndo

Comment 16

[Daniela Domnici]

Attachment: skipBeta

Created a new skip patch for the beta branch.

Comment 17

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8553688 [details] [diff] [review]
skipBeta

Review of attachment 8553688 [details] [diff] [review]:
-----------------------------------------------------------------

We're skipping this because the test has several failures on beta. This one, Notification popup state has been opened, aModule.browserWindow is undefined, Share geolocation button has been found.

Comment 18

[Andreea Matei [:AndreeaMatei]]

https://hg.mozilla.org/qa/mozmill-tests/rev/a3bf1e628a0c (beta)
We want on release too as we ran it today and also is affected.

http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=All&from=2015-01-23&to=2015-01-23&test=%2FtestAddons%2FtestServiceInstallDisableEnableRemove.js&func=testDisableEnableRemoveUndo

Comment 19

[Daniela Domnici]

Attachment: skipRelease

Created a new skip patch for the release branch.

Comment 20

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8553690 [details] [diff] [review]
skipRelease

Review of attachment 8553690 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/9e4cf8a3b117 (release)

Comment 21

[Cosmin Malutan, [:cosmin-malutan]]

I tried to reproduce this today, I ran the affected test in loop for about 40 times and 10 complete testruns but I couldn't reproduce it.

Comment 22

[Andreea Matei [:AndreeaMatei]]

You tried on an affected machine or locally?

Comment 23

[Cosmin Malutan, [:cosmin-malutan]]

Yes, I tried the same on a production node, I had the same output, it didn't failed.

Comment 24

[Cosmin Malutan, [:cosmin-malutan]]

Since the issue was fixed in the dependent bug, I investigated the difference in the test version that failed and the default one that it didn't. So what we had was also a bug that failed to cancel the uninstall, but which didn't got backported to beta.
This is bug 1094784.

Comment 25

[Cosmin Malutan, [:cosmin-malutan]]

For release we need the fix from bug 1088551, so I guess we could let the train handle it.

Comment 26

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: re-enable patch beta

The fix has been transplanted to beta and release, so the test can be re-enabled.

Comment 27

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8561910 [details] [diff] [review]
re-enable patch beta

Review of attachment 8561910 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/824df1633656 (beta)

On release it doesn't apply.

Comment 28

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: re-enable patch release

Here is the patch for release

Comment 29

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8562557 [details] [diff] [review]
re-enable patch release

Review of attachment 8562557 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/af0997254c51 (release)