1112522 - hg pushes should not be able to create corrupt entries in change_properties.property_value of buildbot_schedulers database

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

In bug 1112456 we had a situation where a particular hg push was able to block all tests from running across all trees due to it creating a truncated entry in change_properties.property_value of buildbot_schedulers database.

Our buildbot code should not allow such an entry to enter the database.

Comment 1

[Gregory Szorc [:gps]]

I pushed >7000 changesets to Try today in small batches so I would avoid this bug. I think it worked. I don't plan on making any large Try pushes any time soon. Hopefully you don't have to worry about anyone triggering this for a while :)

Comment 2

[Chris AtLee [:catlee]]

Attachment: take into account json overhead

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8566933 [details] [diff] [review]
take into account json overhead

Review of attachment 8566933 [details] [diff] [review]:
-----------------------------------------------------------------

<hack stamp>

Comment 4

[Chris AtLee [:catlee]]

hopefully this sticks