Closed
Bug 1112693
Opened 10 years ago
Closed 9 years ago
Add Android 4.2, 4.3, 4.4, 5.0 to Treeherder UI thPlatformNameMap
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file, 3 obsolete files)
993 bytes,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1071572 +++ https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/values.js#L7 needs api11 entries for android-4-2, android-4-3 and android-4-4. We might as well add android-5.0 while we are at it. This is needed for Autophone at a minimum.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8537978 -
Flags: review?(jlund)
Comment 2•10 years ago
|
||
Comment on attachment 8537978 [details] [diff] [review] bug-1112693.patch We don't need the API10 additions, the existing line is just for legacy reasons (will be removed once old jobs are purged). Also, I'm questioning whether we need both the generic and the API11+ varients. Redirecting the review to Ryan, since he has more of an opinion on the naming consistency :-)
Attachment #8537978 -
Flags: review?(jlund) → review?(ryanvm)
Comment 3•10 years ago
|
||
Comment on attachment 8537978 [details] [diff] [review] bug-1112693.patch Review of attachment 8537978 [details] [diff] [review]: ----------------------------------------------------------------- I think Ed covered the points I'd make on this too. We should only need the API11+ entries.
Attachment #8537978 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 4•10 years ago
|
||
new patch with api10 removed, carrying forward r+. How should this get checked in?
Attachment #8538022 -
Flags: review+
Comment 5•10 years ago
|
||
Comment on attachment 8538022 [details] [diff] [review] bug-1112693-v2.patch Review of attachment 8538022 [details] [diff] [review]: ----------------------------------------------------------------- ::: webapp/app/js/values.js @@ +31,3 @@ > "android-4-4": "Android 4.4", > + "android-4-4-armv7-api11": "Android 4.4 API11+", > + "android-5-0": "Android 5.0", I don't think you need this either (any forthcoming 5.0 jobs will almost certainly be on API11+ builds only). Unless you're already running them somewhere else outside of buildbot?
Updated•10 years ago
|
Attachment #8537978 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8538022 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Comment on attachment 8538038 [details] [diff] [review] bug-1112693-v3.patch Review of attachment 8538038 [details] [diff] [review]: ----------------------------------------------------------------- Forgot to qref? :)
Attachment #8538038 -
Flags: review?(ryanvm)
Assignee | ||
Comment 8•10 years ago
|
||
well, amend my commit, yeah. sorry.
Attachment #8538038 -
Attachment is obsolete: true
Attachment #8538042 -
Flags: review?(ryanvm)
Updated•10 years ago
|
Attachment #8538042 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 9•9 years ago
|
||
What is the approved approach to get this checked in?
Flags: needinfo?(mdoglio)
Flags: needinfo?(emorley)
Comment 10•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/6f631e39c223cc6ccddc827536aa3ef1c9fcaa65 Bug 1112693 - Add more platform mappings for split apk Android; r=ryanvm
Comment 11•9 years ago
|
||
I've checked it in now. Sorry this got overlooked - we normally use pull requests (with redirect attachments on bugs), and the pull requests are listed out on Github. This bug also had no assignee, so didn't appear in the list (that I glance through periodically) at: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Assigned
Assignee: nobody → bob
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(mdoglio)
Flags: needinfo?(emorley)
Resolution: --- → FIXED
Comment 12•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/8ce16a4feef0d0350622789e754695ad91696ed6 Bug 1112693 - Add more platform mappings for split apk Android; r=ryanvm
You need to log in
before you can comment on or make changes to this bug.
Description
•