1113040 - [ERROR] Internal error dispatching command “goto-url-newtab”. / [ERROR] TypeError: browserWin.content is null @<chrome://chatzilla/content/commands.js> 2234

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Nicholas Nethercote [inactive]]

I'm using the ChatZilla nightly from http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.91/201412112314/chatzilla-0.9.91-201412112314.xpi. I get the following errors when I click on a link:

> [ERROR] Internal error dispatching command “goto-url-newtab”.
> [ERROR] TypeError: browserWin.content is null @ <chrome://chatzilla/content/commands.js> 2234

and the link doesn't open.

Comment 1

[:Gijs (he/him)]

Is this with or without e10s?

Comment 2

[:Gijs (he/him)]

This is e10s-only, I can reproduce.

Comment 3

[:Gijs (he/him)]

Attachment: fix content access in CZ,

This should do, I think.

Comment 4

[:Gijs (he/him)]

Attachment: chatzilla-0.9.91.xpi

Here's an XPI that you can use which should work (wfm, at least).

As best I can tell this is the only use of window.content in CZ, so this should be the only other e10s fix we need (knock on wood).

Comment 5

[Nicholas Nethercote [inactive]]

> Here's an XPI that you can use which should work (wfm, at least).

Works for me, too! Thank you for the quick fix.

Comment 6

[Glen Mailer]

Do we no longer need to retain backwards-compatibility for browser versions that don't have the gBrowser property?

Comment 7

[:Gijs (he/him)]

(In reply to Glen Mailer from comment #6)
> Do we no longer need to retain backwards-compatibility for browser versions
> that don't have the gBrowser property?

... maybe? :-)

gBrowser predates the hg switch (in 2007) for Firefox. Don't know about seamonkey, but it's been in use there a while, too, AFAICT. Don't know what our explicit requirements are, I'll leave that to Silver.

Comment 8

[:Gijs (he/him)]

Note also that this might break old songbird. I'm... not really bothered, I have to say.

Comment 9

[James Ross]

Comment on attachment 8538654 [details] [diff] [review]
fix content access in CZ,

Review of attachment 8538654 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy if everything recent (last 6 months) works. We should kill the rest, especially including Songbird.

Comment 10

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/5fbe9644bfae

Filed bug 1113707 to get rid of songbird compat.