Closed
Bug 1113147
Opened 10 years ago
Closed 9 years ago
Revert the hack from bug 1108809 and blacklist SOAP::Lite 1.12
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: dkl, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
A custom hack was added to Bugzilla/WebService/Server/XMLRPC.pm in bug 1108809 that worked around an issue with SOAP::Lite version 1.12. Once 1.13 is released, this bug is about removing the hack and blacklist SOAP::Lite version 1.12. If this happens before 5.0 final is released, we will remove the change in that branch as well. If not, we will do it in the next minor stable release. dkl -- Original issue -- https://travis-ci.org/bugzilla/bugzilla/jobs/43374627 Apache error log shows multiple: [Mon Dec 8 21:21:43 2014] xmlrpc.cgi: Can't use string ("") as a subroutine ref while "strict refs" in use at /home/travis/perl5/perlbrew/perls/5.16/lib/site_perl/5.16.3/SOAP/Transport/HTTP.pm line 384. Will investigate further. dkl
|
Assignee | |
Comment 1•9 years ago
|
||
I got an email from the maintainer of SOAP::Lite 15 minutes ago. 1.13 is on the way to CPAN: https://github.com/redhotpenguin/soaplite/commit/a4e707381634c43cf96c59c0fa7c9cbde34ffe34
|
|
Assignee | |
Comment 2•9 years ago
|
||
1.13 is now available on CPAN: http://search.cpan.org/~phred/SOAP-Lite-1.13/
|
|
Assignee | |
Updated•9 years ago
|
Flags: blocking5.0?
Target Milestone: --- → Bugzilla 5.0
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Summary: Remove hack in Bugzilla/WebService/Server/XMLRPC.pm due to issue with SOAP::Lite version 1.12 when 1.13 is released → Revert the hack from bug 1108809 and blacklist SOAP::Lite 1.12
i don't think it's worth blocking the 5.0 release for this change (but of course we should take it on the 5.0 branch if it's good to go prior to release).
Flags: blocking5.0? → blocking5.0-
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8543272 [details] [diff] [review] patch, v1 Review of attachment 8543272 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl for trunk and for 5.0. dkl
Attachment #8543272 -
Flags: review?(dkl) → review+
|
|
Reporter | |
Updated•9 years ago
|
Flags: approval?
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
|
|
Assignee | |
Comment 6•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 26db658..41a35f6 master -> master To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git a5758fa..eb9af16 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•