1113477 - GMPParent send node id logged as a failure

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In GMPParent we log the sending of node id to a child as a failure:

LOGD(("%s::%s: Failed to send node id %p", __CLASS__, __FUNCTION__, (void *)mProcess));

But it's actually not failed when we log this...

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Who says I can't do useful work on the last day of the year?

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8538978 [details] [diff] [review]
Patch

Review of attachment 8538978 [details] [diff] [review]:
-----------------------------------------------------------------

Add a LOGE() to the |!ok| blocks with the original messages.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

There's no LOGE here, so I went with LOGD:
https://hg.mozilla.org/integration/mozilla-inbound/rev/446f986dd668

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/446f986dd668