1113837 - Build display-list dumping without MOZ_DUMP_PAINTING

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

The display-list dump is now a central feature for graphics debugging and will now be used by the profiler to visualize painting. We should make this available by default.

Comment 1

[Markus Stange [:mstange]]

Comment on attachment 8539515 [details] [diff] [review]
patch

Review of attachment 8539515 [details] [diff] [review]:
-----------------------------------------------------------------

What's the reason for the gfxUtils.cpp change? I think checking an env variable just once on startup should be fine, performance-wise.

Comment 2

[Benoit Girard (:BenWa)]

I didn’t want to check an env variable for something that would never get used

Comment 3

[Benoit Girard (:BenWa)]

Attachment: patch v2

Forgot to remove the #ifdef for nsDisplayGeneric::mName.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch v3

does what I said in v2 but properly this time.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: patch v4

minor tweaks

Comment 6

[Benoit Girard (:BenWa)]

Attachment: patch v5

Comment 7

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=28612b199ee1

Comment 8

[Benoit Girard (:BenWa)]

Attachment: Valgrind malloc / delete mismatch

UniqueSelector calls operator new whichs gets translated to valgrind's memcheck malloc, but the UniquePtr reset() calls memchecks operator delete.

Could this be a bug in either memcheck or our memory shim? Outwardly we're calling both opeator new / operator delete.

Comment 9

[Julian Seward [:jseward]]

(In reply to Benoit Girard (:BenWa) from comment #8)
> Could this be a bug in either memcheck or our memory shim? Outwardly we're
> calling both opeator new / operator delete.

The Gecko code is fine; you can safely ignore this.  FWIW it happens because
|operator new| is inlined into its caller |detail::UniqueSelector|

==47856==    by 0x7625757: moz_xmalloc (mozalloc.cpp:52)
==47856==    by 0x9807C96: operator new (mozalloc.h:210)
==47856==    by 0x9807C96: mozilla::detail::UniqueSelector<std::basic_st[..]

whereas |operator delete| isn't

==47856==    at 0x4C2827E: operator delete(void*) (in /usr/lib64/valgrin[..]
==47856==    by 0x54F5D6C: std::basic_stringstream<char, std::char_trait[..]

so Memcheck can intercept calls to |delete| but there's no call to |new|
to intercept; instead it intercepts only the |malloc| called by |new|.

For now you can run with --show-mismatched-frees=no.  Alternatively try
building Fx with -O2, since I suspect that increases the inlining aggressiveness
and causes both |new| and |delete| to get inlined, removing the asymmetry.

Comment 10

[Benoit Girard (:BenWa)]

Attachment: patch v6

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65adc56e14a9

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/65adc56e14a9