Closed Bug 1115145 Opened 10 years ago Closed 10 years ago

Convert some occurences of ns*Array.IndexOf(elem) != kNotFound to ns*Array.Contains(elem)

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 37.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
6.47 KB, patch
neil
: review+
Details | Diff | Splinter Review 
Using the native ns*Array.Contains(elem) function seems more correct.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8540943 -
        Flags: review?(neil)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  
One more.

        Attachment #8540943 -
        Attachment is obsolete: true

        Attachment #8540943 -
        Flags: review?(neil)

        Attachment #8540951 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 8540951 [details] [diff] [review]
patch v2

r=me by code inspection.

        Attachment #8540951 -
        Flags: review?(neil) → review+

    
    

    
  
Thaks.
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/47fbea249717 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: