Closed
Bug 1115374
Opened 9 years ago
Closed 9 years ago
DevEdition theme - Inconsistent borders on toolbars
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 38
People
(Reporter: ntim, Assigned: bgrins)
References
Details
(Whiteboard: [devedition-polish][testday-20150901])
Attachments
(1 file, 1 obsolete file)
1.48 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
See attachment 8536605 [details], the navbar doesn't borders on the sides, while the bookmarks toolbar does have some. This makes the light theme look unpolished.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [devedition-polish]
Assignee | ||
Comment 1•9 years ago
|
||
It appears in the screenshot that you have the patch from Bug 1093820 applied. Do you see this problem even without that?
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1) > It appears in the screenshot that you have the patch from Bug 1093820 > applied. Do you see this problem even without that? Yes. I see that without the patch.
Assignee | ||
Comment 3•9 years ago
|
||
Tim, does it look better with this patch applied?
Attachment #8549144 -
Flags: feedback?(ntim007)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8549144 [details] [diff] [review] toolbar-border-windows.patch Review of attachment 8549144 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the issue for me.
Attachment #8549144 -
Flags: feedback?(ntim007) → feedback+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8549144 [details] [diff] [review] toolbar-border-windows.patch Checked on OSX and Ubuntu and this Windows fix doesn't seem to cause any changes, so requesting review
Attachment #8549144 -
Flags: review?(gijskruitbosch+bugs)
Comment 6•9 years ago
|
||
Comment on attachment 8549144 [details] [diff] [review] toolbar-border-windows.patch Review of attachment 8549144 [details] [diff] [review]: ----------------------------------------------------------------- This was annoying me the other day on win8. Thanks!
Attachment #8549144 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Adds commit message
Assignee: nobody → bgrinstead
Attachment #8549144 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Attachment #8549190 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=327be8db5e75
Keywords: checkin-needed
Comment 9•9 years ago
|
||
Hi, seems this doesn't apply cleanly: patching file browser/themes/shared/devedition.inc.css Hunk #2 FAILED at 221 1 out of 2 hunks FAILED -- saving rejects to file browser/themes/shared/devedition.inc.css.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh toolbar-border-windows.patch could you take a look, thanks!
Flags: needinfo?(bgrinstead)
Keywords: checkin-needed
Assignee | ||
Comment 11•9 years ago
|
||
Rebased and pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/2cc184d6dc0f
Flags: needinfo?(bgrinstead)
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
https://hg.mozilla.org/mozilla-central/rev/2cc184d6dc0f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 38
Comment 13•9 years ago
|
||
This has been verified fixed for a QA test day.
Status: RESOLVED → VERIFIED
Whiteboard: [devedition-polish] → [devedition-polish][testday-20150901]
You need to log in
before you can comment on or make changes to this bug.
Description
•