Closed
Bug 1115494
Opened 9 years ago
Closed 9 years ago
[RTL] Share activity menu icons are not right-alined
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.2 verified)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | verified |
People
(Reporter: nefzaoui, Assigned: nefzaoui)
References
Details
Attachments
(4 files)
The share activity menu icons are currently to the far left in RTL, however, they need to be right-alined.
Assignee | ||
Updated•9 years ago
|
Blocks: system-rtl
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
How the bug looks like.
Assignee: nobody → nefzaoui
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8541415 [details] [review] [PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master Small one, please review? Thanks!
Attachment #8541415 -
Flags: review?(dflanagan)
Comment 5•9 years ago
|
||
Comment on attachment 8541415 [details] [review] [PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master I'm not an appropriate reviewer for this patch. mhenretty has reviewed one that touches this file recently, however, so maybe he could review or pass it on to someone appropriate.
Attachment #8541415 -
Flags: review?(dflanagan) → review?(mhenretty)
Comment 6•9 years ago
|
||
Comment on attachment 8541419 [details]
Screenshot - Patch Applied
Looks good. Thanks, Ahmed. I apologize for the delay; I was off for the Christmas holiday with family. :)
Attachment #8541419 -
Flags: ui-review?(swilkes) → ui-review+
Comment 7•9 years ago
|
||
Comment on attachment 8541415 [details] [review] [PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master Code looks good, and works like a charm. Left one mega tiny nit on github, but r=me.
Attachment #8541415 -
Flags: review?(mhenretty) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Hey Michael, Left you a comment on the PR, could you please let me know what do you think? Thanks!
Flags: needinfo?(mhenretty)
Comment 11•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list. Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Updated•9 years ago
|
Keywords: checkin-needed
Comment 12•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list. Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Comment 13•9 years ago
|
||
Comment on attachment 8541415 [details] [review] [PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master Throwing in my review stamp to appease Autolander. Not sure why it commented twice, should fix that..
Attachment #8541415 -
Flags: review+
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 14•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1be6a7672f63ead6eca34941df2b6407e4c0ea19
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 15•9 years ago
|
||
This issue does not exist on Flame 2.2 Gaia-Rev 7c5b27cad370db377b18a742d3f3fdb0070e899f Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382 Build-ID 20150115002505 Version 37.0a2 Reproduce rate 0/5
You need to log in
before you can comment on or make changes to this bug.
Description
•