Closed
Bug 1116545
Opened 9 years ago
Closed 9 years ago
Remove the code to handle shutdown-cleanse from the cache service
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.79 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
shutdown-cleanse has not been a thing for quite a while.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8542631 -
Flags: review?(mcmanus)
Comment 2•9 years ago
|
||
Comment on attachment 8542631 [details] [diff] [review] Remove the code to handle shutdown-cleanse from the cache service Review of attachment 8542631 [details] [diff] [review]: ----------------------------------------------------------------- toss to honza
Attachment #8542631 -
Flags: review?(mcmanus) → review?(honzab.moz)
Comment 3•9 years ago
|
||
Comment on attachment 8542631 [details] [diff] [review] Remove the code to handle shutdown-cleanse from the cache service Looks ok for me, but let rather Michal check quickly.
Attachment #8542631 -
Flags: review?(honzab.moz) → review?(michal.novotny)
Assignee | ||
Comment 4•9 years ago
|
||
FWIW this is dead code elimination.
Updated•9 years ago
|
Attachment #8542631 -
Flags: review?(michal.novotny) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb57bc86d90b
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb57bc86d90b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 8•9 years ago
|
||
Fwiw, do we want to remove the following last comment too? http://mxr.mozilla.org/mozilla-central/search?string=shutdown-cleanse&case=on {{ /profile/notifications.txt * line 59 -- NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was }}
You need to log in
before you can comment on or make changes to this bug.
Description
•