Closed
Bug 1116753
Opened 9 years ago
Closed 9 years ago
Remove the nsIPresShell* param from all frame ctors
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
57.92 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We've already done this for almost all frames, but not for XUL frames and a few others.
|
Assignee | |
Comment 1•9 years ago
|
||
Most ctors are now 1-arg ctors so I added 'explicit' to those. There were only a couple of places where the shell was actually used. I replaced it with PresContext()->PresShell() which should work fine in the body of a frame ctor. Other than that, no significant changes. https://tbpl.mozilla.org/?tree=Try&rev=01359209c378
Attachment #8542954 -
Flags: review?(roc)
Attachment #8542954 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/426055dc106a
Flags: in-testsuite-
|
|
Assignee | |
Comment 3•9 years ago
|
||
I missed an 'explicit' in one place which caused static analysis to fail, so I landed this follow-up to fix that: https://hg.mozilla.org/integration/mozilla-inbound/rev/3405b354e2f1
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/426055dc106a https://hg.mozilla.org/mozilla-central/rev/3405b354e2f1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•