1116802 - browser/devtools/webide/test/test_zoom.html leaves a webide window open after it is completed

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

while testing some fixes locally on a mochitest-chrome test, I noticed that there was a random window sitting around.  Doing some basic sleuthing, I found this to be in the webide directory, and a few test runs yielded test_zoom.html as the culprit:
http://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/test/test_zoom.html

it appears we:
* launch the webide
* zoom, etc.
* close the webide
* launch the webide
* zoom, etc.
* finish

^ notice, we don't appear to have code that closes the webide on the second time.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks Joel, this is a great simple example for me to try out. I will attach my patch in a little bit (am running tests locally just to make sure I am following the correct process).

I am still not sure how to tell what might have been originally calling this or making it fail (It didn't fail when I ran the test)  But maybe that depends on running the full set of tests, or on a particular platform or something. It makes sense that this would probably fix whatever it was, though.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Attachment: bug-1116802-fix.patch

Here you go. I ran the mochitest-chrome tests on browser/devtools/webide/test/ . Nothing failed and no spare WebIDE windows lingered.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8543436 [details] [diff] [review]
bug-1116802-fix.patch

Review of attachment 8543436 [details] [diff] [review]:
-----------------------------------------------------------------

This is great!  I would be comfortable r+'ing the patch, but in this case lets ask the original test author to review it.  Just in case there is some odd reason why it was written that way.

Comment 4

[Paul Rouget [:paul]]

Comment on attachment 8543436 [details] [diff] [review]
bug-1116802-fix.patch

Oops :)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c66197902d87

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

ok, thanks Liz and Paul!

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c66197902d87