1116869 - Make outgoing use the same auto --rev logic as push

Status: RESOLVED FIXED

(Developer Services :: Mercurial: firefoxtree, defect)

Description

[Dave Townsend [:mossop]]

I like to use "hg outgoing" before I push to make sure I'm pushing the right things and haven't accidentally ended up with stuff in my tree I don't expect. But with firefoxtree installed "hg outgoing" doesn't show the same changesets as "hg push" will push because the latter defaults to "-r ." when pushing to a mozilla repo. outgoing should use the same defaults so I see the right changesets.

Comment 1

[Gregory Szorc [:gps]]

This is a reasonable request. I should be able to bang this out real quick.

Comment 2

[Gregory Szorc [:gps]]

Attachment: firefoxtree: limit heads during outgoing against a Firefox repo ()

firefoxtree already limits considered revisions when interacting with
Firefox trees via `hg push`. This change extends similar functionality
to `hg outgoing` checks.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8544371 [details] [diff] [review]
firefoxtree: limit heads during outgoing against a Firefox repo ()

Review of attachment 8544371 [details] [diff] [review]:
-----------------------------------------------------------------

::: hgext/firefoxtree/__init__.py
@@ +317,5 @@
> +    low-level API used by discovery. Manipulating it could lead to unintended
> +    consequences.
> +    """
> +    tree, uri = resolve_trees_to_uris([dest])[0]
> +    if isfirefoxrepo(repo) and uri:

This differs from the behaviour for |hg push|, in that for push, using '.' isn't conditional on isfirefoxrepo():
https://hg.mozilla.org/hgcustom/version-control-tools/file/0b384be2ce9b/hgext/firefoxtree/__init__.py#l165

Should the behaviour for both be consistent?

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/1b9e2b8fccb3

Comment 5

[Ralph Giles (:rillian)]

Thanks, gps!