Closed Bug 1117014 Opened 9 years ago Closed 9 years ago

Intermittent marketplace_test.js | search/providers/marketplace mock response renders all results - req is undefined

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S14 (12june)

People

(Reporter: philor, Assigned: kgrandon)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(2 files)

      No description provided.
Whiteboard: [systemsfe]
Frequent since the TC switch.
Flags: needinfo?(kgrandon)
Flags: needinfo?(jlal)
Comment on attachment 8583977 [details] [review]
[gaia] KevinGrandon:bug_1117014_search_marketplace_response_test > mozilla-b2g:master

This could possibly fix the issue. Let's land and see if we keep seeing this. R=me for the testonly change.
Flags: needinfo?(kgrandon)
Attachment #8583977 - Flags: review+
Assignee: nobody → kgrandon
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(jlal)
Target Milestone: --- → 2.2 S14 (12june)
Looks like this is back.
Flags: needinfo?(kgrandon)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8634512 [details] [review]
[gaia] KevinGrandon:bug_1117014_marketplace_intermittent_test > mozilla-b2g:master

Here is an attempt to better safeguard the promise. Let's see what this does on try. R=me for this simple testonly change and to try to fix the intermittent.
Flags: needinfo?(kgrandon)
Attachment #8634512 - Flags: review+
In master: https://github.com/mozilla-b2g/gaia/commit/e7f99d8c7e0fbc2fa31490ee85429992c86c1c6f
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: