1117037 - Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[(no longer active)]

Attachment: Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8543220 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

r=me if you fix up the over long lines (a whole bunch are over 80 chars)

Comment 3

[(no longer active)]

(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> r=me if you fix up the over long lines (a whole bunch are over 80 chars)

Which lines specifically?  The code around most of what I touched currently has no respect for 80 column limit.

Comment 4

[alexander :surkov (:asurkov)]

if there's a whole bunch of them before patching then it should be ok take the patch as is if you don't feel brave enough to fix them :)

Comment 5

[(no longer active)]

Yep, thanks Alexander!  Bigger fish to fry and all.  :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/539768eaa7ba

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/539768eaa7ba

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > r=me if you fix up the over long lines (a whole bunch are over 80 chars)
> 
> Which lines specifically?  The code around most of what I touched currently
> has no respect for 80 column limit.

I didn't look at the surrounding stuff.  I'd prefer we not add additional violations, but I don't really care for that rule anyway so whatever.