Closed
Bug 1117197
Opened 9 years ago
Closed 9 years ago
protocol.js actors produce the wrong error message when receiving a misformed packet
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
When an actor defined using protocol.js receives a misformed packet, it complains "Error writing request", when it should say "Error reading request".
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jimb
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8543372 -
Flags: review?(dcamp)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8543372 [details] [diff] [review] Fix error message produced when receiving a misformed request Sometimes I feel like bugzilla requests are not "could you please verify that I did this patch correctly", but rather "could you please acknowledge that you did something incorrectly."
Attachment #8543372 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
No comment! [birds chirping] https://hg.mozilla.org/integration/mozilla-inbound/rev/081f35abf3bb
Severity: normal → trivial
Flags: in-testsuite-
Target Milestone: --- → Firefox 37
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/081f35abf3bb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•