1117267 - Uninline Debugger::isDebuggee() to fix -Wundefined-inline warning

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: js-Debugger_Wundefined-inline.patch

JSCompartment::maybeGlobal() is declared inline, but is called by Debugger::isDebuggee() before its inline definition has been seen:

> Warning: -Wundefined-inline in js/src/jscompartment.h: inline function 'JSCompartment::maybeGlobal' is not defined
> js/src/jscompartment.h:215:30: warning: inline function 'JSCompartment::maybeGlobal' is not defined [-Wundefined-inline]
>      inline js::GlobalObject *maybeGlobal() const;
>                               ^
> js/src/vm/Debugger.h:239:72: note: used here
>          return compartment->isDebuggee() && debuggees.has(compartment->maybeGlobal());
>                                                                         ^

Comment 1

[Chris Peterson [:cpeterson]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/595796592856

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/595796592856