1117350 - Implement %TypedArray%.prototype.{reduce, reduceRight}

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Comment 1

[ziyunfei]

I found we already have a "TypedArrayReduce" method in http://dxr.mozilla.org/mozilla-central/source/js/src/builtin/TypedObject.js#669, so how shall we name this "reduce" method in TypedArray.js?

Comment 2

[Till Schneidereit [:till]]

(In reply to ziyunfei from comment #1)
> I found we already have a "TypedArrayReduce" method in
> http://dxr.mozilla.org/mozilla-central/source/js/src/builtin/TypedObject.
> js#669, so how shall we name this "reduce" method in TypedArray.js?

That function should be renamed to TypedObjectArrayReduce. R=me on s/TypedArray/TypedObjectArray/ for all functions in TypedObject.js.

Comment 3

[ziyunfei]

Attachment: s/TypedArray/TypedObjectArray/ in TypedObject.js and TypedObject.cpp

Comment 4

[Till Schneidereit [:till]]

Comment on attachment 8543653 [details] [diff] [review]
s/TypedArray/TypedObjectArray/ in TypedObject.js and TypedObject.cpp

Review of attachment 8543653 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[ziyunfei]

Attachment: bug-1117350-part2-v1.patch

Comment 6

[ziyunfei]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b210bd684755

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f09142ac24fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b29b9cdedfc

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f09142ac24fc
https://hg.mozilla.org/mozilla-central/rev/3b29b9cdedfc

Comment 9

[Tooru Fujisawa [:arai]]

Updated following documents:
  https://developer.mozilla.org/en-US/Firefox/Releases/37
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reduce
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reduceRight

Comment 10

[Florian Scholz (Open Web Docs)]

Great, thanks a lot!