1117662 - video recording have green bar on left side

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[becker hsieh{:behsieh}]

recorded video file in Android L porting have green bar in left side.

Comment 1

[becker hsieh{:behsieh}]

root cause is , in Android.mk under device/lge/hammerhead/camera/QCamera2/stack/mm-camera-interface
there is a define as below
ifeq ($(call is-board-platform-in-list,msm8974 msm8226),true)
    LOCAL_CFLAGS += -DVENUS_PRESENT
endif
we can not find this define is-board-platform-in-list in 2.2 code base.

Comment 2

[Michael Vines [:m1] [:evilmachines]]

It's usually in device/qcom/common/utils.mk, such as https://www.codeaurora.org/cgit/quic/la/device/qcom/common/tree/utils.mk?id=LNX.LA.3.7.2.1.c4-01700-8x16.0#n98

Comment 3

[becker hsieh{:behsieh}]

I get code from codeaurora from below link
https://www.codeaurora.org/cgit/quic/la/device/qcom/common/?h=l_master
looks like utils.mk included by base.mk
and base.mk include by common.mk and common64.mk
in my code base , i could not found who include common.mk or common64.mk

Comment 4

[Michael Vines [:m1] [:evilmachines]]

Here's one such example: https://www.codeaurora.org/cgit/quic/la/platform/vendor/qcom/msm8610/tree/msm8610.mk?h=LA.BF.1.1.1_rb1.1&id=LNX.LA.3.7.2.1.c4-01700-8x16.0#n20

You may want to sync a pure Android build for your N5 as reference.

Comment 5

[becker hsieh{:behsieh}]

Attachment: enable VENUS on 8974 and 8226 platform

fix camera green bar in left side

Comment 6

[becker hsieh{:behsieh}]

Attachment: enable VENUS on 8974 and 8226 platform

fix camera green bar in left side

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8545640 [details] [review]
enable VENUS on 8974 and 8226 platform

Looks good to me.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8545639 [details] [review]
enable VENUS on 8974 and 8226 platform

Looks good to me.

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/b2g-manifest/commit/62d6773500827ed8a6855f32392022ba004d6f62
https://github.com/mozilla-b2g/device-hammerhead/commit/ad8030b3b32b9a78116db6b605b3e1d90bf0fda0

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

This commit is missed in 2.2 branch. Without this camera recording will get some issue.

Comment 11

[becker hsieh{:behsieh}]

this fix needs to phase in v2.2

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/89b3f66acc69f0fa44fb27dce40bfe34eaf6b641

Comment 13

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: framegrab showing green stripe (frame should be rotated 90° clockwise) - away-facing camera

I've confirmed that my tree has the attached patches, but I'm still seeing green stripes down the sides of my recorded videos.

- gecko master:ba2f5fcd614709cb2ec0a69d685c89bc8d454c9b
- gaia  master:be64e0a1412c1b8c40b7597c77ed16841bdb152f

User-facing camera: stripe is 32px wide, on the right side of the video.
Away-facing camera: stripe is 16px wide, on the left side of the video.

Comment 14

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: framegrab showing green stripe (frame should be rotated 90° clockwise) - user-facing camera

Comment 15

[becker hsieh{:behsieh}]

hi mike:
i just do repo sync and clean build.
stripe seems not exist.
you also could check below git whether include fixed patch.
B2G/device/lge/hammerhead/camera/QCamera2
commit ad8030b3b32b9a78116db6b605b3e1d90bf0fda0

B2G/.repo/manifests
commit 1c965d284fbc9886ce3be156960bf6f23149d832
thanks

Comment 16

[becker hsieh{:behsieh}]

from Bug 1120780 comment 34.
we will going to revert this patch.

Comment 17

[becker hsieh{:behsieh}]

Attachment: revert request from caf

Comment 18

[becker hsieh{:behsieh}]

Attachment: revert android.mk change

Comment 19

[Michael Wu [:mwu]]

Comment on attachment 8568411 [details] [review]
revert android.mk change

This PR is against the wrong branch.

Comment 20

[Michael Wu [:mwu]]

Comment on attachment 8568409 [details] [review]
revert request from caf

r=me with a more descriptive commit message. "BUG" in all caps also looks particularly wrong for some reason.

Comment 21

[becker hsieh{:behsieh}]

Attachment: revert android.mk change

change pull request branch to b2g-5.0.0_r6

Comment 22

[becker hsieh{:behsieh}]

Attachment: revert android.mk change

change PR branch to b2g-5.0.0_r6

Comment 23

[becker hsieh{:behsieh}]

Attachment: revert bug 1117662 chage

remove a line which is get code from caf

Comment 24

[Michael Wu [:mwu]]

Attachment: Force mmcamera_interface to use the venus codepath

This ensures that the venus code path is selected without relying on build functions that aren't in our codebase. Fixes the green stripe for me.

Comment 25

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8578417 [details] [review]
Force mmcamera_interface to use the venus codepath

LGTM.

Comment 26

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/device-hammerhead/commit/30c43bc43f4393ad1ff602646d8b641067f83189
https://github.com/mozilla-b2g/device-hammerhead/commit/c37663f828891cf7a49451a04f3f1ce7f7e5c054

Comment 27

[Michael Wu [:mwu]]

Attachment: Revert manifest changes from this bug (master branch)

Comment 28

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/b2g-manifest/commit/a36d11cdfe7272f1d47f40d215feb8367b718259
https://github.com/mozilla-b2g/b2g-manifest/commit/dd3e1f4f8fc1d601d6e54a960a2509f2049e25c8