1118049 - Can't enter 0.1MB as value for data usage limit in the cost control app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Martijn Wargers (dead)]

This is reproducable with:
Gaia-Rev        698e6e8a098cc060b26cd6f25171633c4c7e739d
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/13fe5ad0364d
Build-ID        20150102010205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

I think this used to work with a build from a week ago or so.

Steps to reproduce:
- Start up Usage app
- Tap on the Settings icon
- Tap on select just under "When use is above" -> Data usage limit dialog opens
- Try to enter "0.1" as value in the input at the bottom

Expected result:
- 0.1 is entered as value

Actual result:
- 0.1 is not accepted as value

This prevents bug 1115180 to be re-enabled.

Comment 1

[Viorela Ioia [:viorela]]

Marina, Vivien, can you please take a look over this issue? 
We cannont re-enable a smoketest because of this.
Thanks!

Comment 2

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva, 
would you mind reviewing the patch?
Regards

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8548692 [details] [review]
patch v1.0

Not sure. We should check with UX if unit fractions are valid values. Delaying review until feedback from UX is provided.

Juwei, could you please tell us if 0.1M or 0.1G are valid values for data alerts?

Comment 4

[Juwei Huang[:juwei]]

Hi,
0.1 makes sense to me.
Thanks.

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8548692 [details] [review]
patch v1.0

Marina, address the comments on GitHub and ask for my review again.

Thank you!

Comment 6

[Marina Rodríguez [:mai]]

Comment on attachment 8548692 [details] [review]
patch v1.0

Updated the pr with your comments

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 8548692 [details] [review]
patch v1.0

Just a little comment on GitHub.
Thank you!

Comment 8

[Marina Rodríguez [:mai]]

Master: ec19d7e5bf2aa35ab6628b3c2c7f96b2eae2c031

Comment 9

[Marina Rodríguez [:mai]]

Comment on attachment 8548692 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1089829
[User impact] if declined: The user cannot introduce values that starts with 0. or .
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: No

Comment 10

[Viorela Ioia [:viorela]]

I just verified and this issue is fixed in latest mozilla-central. 
I am able to insert '0.1 MB' as mobile data limit alert. 

Gaia-Rev        ebb5bd74ac660092d863c86e4ccf731b903be2e4
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/cccb55b1561d
Build-ID        20150116052200
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150116.085803
FW-Date         Fri Jan 16 08:58:13 EST 2015
Bootloader      L1TC10011880

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b3bc5ba88f2bef3008f975fc67e28a0d23615faf

Comment 12

[Lance（leave from Mozilla）]

Per comment 10, this bug is fixed/verified, so change status and "Tracking Flags" to "verified