Closed
Bug 1118413
Opened 9 years ago
Closed 9 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in places; r=mak
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
31.75 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8553313 -
Flags: review?(mak77)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8553313 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in places Review of attachment 8553313 [details] [diff] [review]: ----------------------------------------------------------------- wow, this sounds like a huge effort, especially when it has to be applied to classes just derived from interfaces.
Attachment #8553313 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
The good news is that if you use the NS_DECL_... macros generated by the XPIDL compiler, it will take care of it for you!
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fdefac62cd56
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•