1118544 - Support installing FxOS extensions from WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[Kevin Grandon :kgrandon]

Extensibility support landed in FxOS in bug 923897. It would be nice if we could leverage WebIDE to develop addons. Currently when trying to open a packaged addon in WebIDE you are brought to an empty, broken screen.

You can see an example of a packaged addon in the patch from bug 923897: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=923897&attachment=8536350

Comment 1

[Alexandre Poirot [:ochameau]]

WFM?

Ryan, do we have anything intermittently broken in package app import workflow??

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: simple addon against clock

Having said that, I can't get a simple addon to work against clock app :/
(I'm using gecko master, not cypress as addon code seems to be on master)

Also, I'm seeing some possible improvements made to WebIDE:
- do not require index.html file before pushing an addon,
- do not try to open addons.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: patch

Implements comment 2 tweaks.

Comment 4

[Kevin Grandon :kgrandon]

I'll try to see if I can reproduce the issue later with the addon in this bug. Thanks for taking a look.

Comment 5

[Kevin Grandon :kgrandon]

This appears the be working for me after updating today. Not sure if I was doing something wrong yesterday. The validation should help if it's an addon though, so I suppose we can keep this bug around just to track the index.html validation. Thanks!

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8545245 [details] [diff] [review]
patch

Review of attachment 8545245 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me!

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #1)
> WFM?
> 
> Ryan, do we have anything intermittently broken in package app import
> workflow??

I am not aware of any issues like that.  Please file if you are seeing them!

Comment 8

[Alexandre Poirot [:ochameau]]

Comment on attachment 8545245 [details] [diff] [review]
patch

Landed on cypress:
  https://hg.mozilla.org/projects/cypress/rev/7c47974930cb

Comment 9

[Alexandre Poirot [:ochameau]]

Try for landing on master:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=35f5c011dfaa

Comment 10

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/7836722086c9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7836722086c9

Comment 13

[Adrian Aichner [:anaran]]

I can confirm comment 3 to work in
navigator.buildID
    20150123030203
navigator.languages
    de
navigator.userAgent
    Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Firefox/38.0

That add-on does not open, on a notification at the bottom of the firefox os device informs about installation.

But I still get
I/pea     ( 6910): Error loading stylesheet app://b1bba6b4-1790-4054-9608-064dd5220203/css/app.css : [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIDOMWindowUtils.loadSheet]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: resource://gre/modules/UserCustomizations.jsm :: this.UserCustomizations._injectItem/< :: line 214"  data: no]
I/pea     ( 6910): Error sandboxing app://b1bba6b4-1790-4054-9608-064dd5220203/report-json-parse-error.js : Error opening input stream (invalid filename?): app://b1bba6b4-1790-4054-9608-064dd5220203/report-json-parse-error.js
I/pea     ( 6910): Error sandboxing app://b1bba6b4-1790-4054-9608-064dd5220203/app.js : Error opening input stream (invalid filename?): app://b1bba6b4-1790-4054-9608-064dd5220203/app.js

I have not been able to find the bug (ISTR one) about this sandboxing issue.

Comment 14

[Adrian Aichner [:anaran]]

I still get the errors shown in my previous comment.

Are there bugs tracking the sandox and loadSheet not impl issue?

I am still seeing this in ...

Close
Runtime Info

ADB is root: yes

Unrestricted DevTools privileges: yes
appid	{3c2e2abc-06d4-11e1-ac3b-374f68613e61}
apptype	b2g
vendor	Mozilla
name	B2G
version	3.0.0.0-prerelease
appbuildid	20150203160231
platformbuildid	20150203160231
platformversion	38.0a1
geckobuildid	20150203160231
geckoversion	38.0a1
changeset	0c2f7434c325
locale	en-US
os	B2G
hardware	qcom
processor	arm
compiler	eabi
brandName	
channel	nightly
profile	default
dpi	254
useragent	Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
width	569
height	320