Closed
Bug 1118548
Opened 9 years ago
Closed 9 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xul; r=baku
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
7.55 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8544909 -
Flags: review?(amarchesini)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8544909 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in dom/xul Review of attachment 8544909 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/xul/templates/nsXULContentBuilder.cpp @@ +90,5 @@ > NS_NewXULContentBuilder(nsISupports* aOuter, REFNSIID aIID, void** aResult); > > nsXULContentBuilder(); > > + void Traverse(nsCycleCollectionTraversalCallback &cb) const MOZ_OVERRIDE ..Callback& aCb ::: dom/xul/templates/nsXULTreeBuilder.cpp @@ +188,5 @@ > virtual nsresult > ReplaceMatch(nsIXULTemplateResult* aOldResult, > nsTemplateMatch* aNewMatch, > nsTemplateRule* aNewMatchRule, > + void *aContext) MOZ_OVERRIDE; void* aContext
Attachment #8544909 -
Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/2dc5720003ee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•