1118550 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml; r=baku

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8544910 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml

Review of attachment 8544910 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xml/nsXMLFragmentContentSink.cpp
@@ +53,2 @@
>    NS_IMETHOD HandleProcessingInstruction(const char16_t *aTarget, 
> +                                         const char16_t *aData) MOZ_OVERRIDE;

1. Can you remove these extra spaces?
2. nsAstring&, char16_t*

@@ +58,1 @@
>    NS_IMETHOD ReportError(const char16_t* aErrorText, 

extra space

@@ +58,4 @@
>    NS_IMETHOD ReportError(const char16_t* aErrorText, 
>                           const char16_t* aSourceText,
>                           nsIScriptError *aError,
> +                         bool *_retval) MOZ_OVERRIDE;

type* aVar

@@ +63,5 @@
>    // nsIContentSink
> +  NS_IMETHOD WillBuildModel(nsDTDMode aDTDMode) MOZ_OVERRIDE;
> +  NS_IMETHOD DidBuildModel(bool aTerminated) MOZ_OVERRIDE;
> +  NS_IMETHOD SetDocumentCharset(nsACString& aCharset) MOZ_OVERRIDE;
> +  virtual nsISupports *GetTarget() MOZ_OVERRIDE;

nsISupports* ..

@@ +79,5 @@
>  
>  protected:
>    virtual ~nsXMLFragmentContentSink();
>  
>    virtual bool SetDocElement(int32_t aNameSpaceID, 

extra space and type* aVar

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f8eb397de371