Closed Bug 1118599 Opened 9 years ago Closed 9 years ago

Use "enum class" directly instead of MOZILLA_PKIX_ENUM_CLASS

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

remove-MOZILLA_PKIX_ENUM_CLASS.patch
37.52 KB, patch
briansmith
: review+
Details | Diff | Splinter Review 
It seems like the GCC compiler bug that I worked around in bug 1077887 is no long relevant. This patch undoes that workaround.

It also renames some things that were named not-so-well do to the need to support non-scoped enums (without "enum class", multiple enums defined in the same scope cannot have the same labels like "No" and "Yes").
Attachment #8544988 - Flags: review?(mmc)
Comment on attachment 8544988 [details] [diff] [review]
remove-MOZILLA_PKIX_ENUM_CLASS.patch

Review of attachment 8544988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning that up.
Attachment #8544988 - Flags: review?(mmc) → review+

        Attachment #8544988 -
        Attachment is obsolete: true

        Attachment #8545642 -
        Flags: review+

        Attachment #8545642 -
        Flags: checkin?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2880e05d5e32
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

        Attachment #8545642 -
        Flags: checkin?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: