1118675 - Improve NetworkService debugging message

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

When reviewing bug 973543 and bug 1104664, I found the logging in NetworkService isn't clear enough for debugging.

In this bug, I would like to improve it.

e.g.

- Add logging when sending message to net_worker, http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkService.js#94-107

- The request id assignment looks a little strange, http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkService.js#99-103
IMO, we should always assign a valid id no matter the callback is available or not. Otherwise, we will see a lot of request and response with id=0, and it's hard to map them together.

- The response always contains a lot attribute because we assign every attribute with a default value in NetworkOptions.webidl. How about make them all optional and only construct it when it is really needed, though I don't know if it is possible.

Comment 1

[Edgar Chen [:edgar]]

Attachment: WIP, Part 1: Improve NetworkService debugging message, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: WIP, Part 2: Remove unused response attribute, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: WIP, Part 3: Unify the attributes for the network command result, v1

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:

Comment 5

[BMO Automation]

Firefox OS is not being worked on