Closed
Bug 1118693
Opened 9 years ago
Closed 9 years ago
[Bluetooth] Port Bug 1095488 to bluetooth2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S5 (6feb)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(4 files)
|
20.45 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
36.43 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
9.63 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
8.02 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8555237 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8555238 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8555240 -
Flags: review?(btian)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8555241 -
Flags: review?(btian)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Like before, the patches are direct conversions from bluetooth/. No extra changes had to be made.
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8555237 [details] [diff] [review] [01] Bug 1118693: Add Bluetooth AVRCP helpers (under bluetooth2/) Review of attachment 8555237 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8555237 -
Flags: review?(btian) → review+
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8555240 [details] [diff] [review] [03] Bug 1118693: Added Bluetooth AVRCP interface (under bluetooth2/) Review of attachment 8555240 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8555240 -
Flags: review?(btian) → review+
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8555241 [details] [diff] [review] [04] Bug 1118693: Added AVRCP support for Bluetooth daemon backend (bluetooth2/) Review of attachment 8555241 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8555241 -
Flags: review?(btian) → review+
|
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8555238 [details] [diff] [review] [02] Bug 1118693: Add Bluetooth AVRCP module (under bluetooth2/) Review of attachment 8555238 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8555238 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 10•9 years ago
|
||
Thanks a lot, Ben! https://hg.mozilla.org/integration/b2g-inbound/rev/0d66f45d7073 https://hg.mozilla.org/integration/b2g-inbound/rev/17b67358ed39 https://hg.mozilla.org/integration/b2g-inbound/rev/6c92b5722fc4 https://hg.mozilla.org/integration/b2g-inbound/rev/b7d0a24739a7 https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=b7d0a24739a7
|
||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0d66f45d7073 https://hg.mozilla.org/mozilla-central/rev/17b67358ed39 https://hg.mozilla.org/mozilla-central/rev/6c92b5722fc4 https://hg.mozilla.org/mozilla-central/rev/b7d0a24739a7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•