Closed
Bug 1118803
Opened 9 years ago
Closed 9 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
22.72 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8545309 -
Flags: review?(amarchesini)
Comment 2•9 years ago
|
||
Comment on attachment 8545309 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code Review of attachment 8545309 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/crypto/WebCryptoTask.cpp @@ +2103,5 @@ > ATTEMPT_BUFFER_ASSIGN(mKeyData, PK11_GetKeyData(symKey)); > return NS_OK; > } > > + virtual void Resolve() MOZ_OVERRIDE { { in a new line. @@ +2108,5 @@ > mKey->SetSymKey(mKeyData); > mResultPromise->MaybeResolve(mKey); > } > > + virtual void Cleanup() MOZ_OVERRIDE { here too ::: dom/devicestorage/nsDeviceStorage.cpp @@ +2931,5 @@ > nsTArray<nsString> emptyOptions; > return nsContentPermissionUtils::CreatePermissionArray(type, access, emptyOptions, aTypes); > } > > + NS_IMETHOD GetPrincipal(nsIPrincipal * *aRequestingPrincipal) MOZ_OVERRIDE nsIPrincipal** @@ +2937,5 @@ > NS_IF_ADDREF(*aRequestingPrincipal = mPrincipal); > return NS_OK; > } > > + NS_IMETHOD GetWindow(nsIDOMWindow * *aRequestingWindow) MOZ_OVERRIDE nsIDOMWindow** @@ +2943,5 @@ > NS_IF_ADDREF(*aRequestingWindow = mWindow); > return NS_OK; > } > > + NS_IMETHOD GetElement(nsIDOMElement * *aRequestingElement) MOZ_OVERRIDE nsIDOMElement** ::: dom/mobileconnection/ipc/MobileConnectionParent.h @@ +35,5 @@ > MOZ_COUNT_DTOR(MobileConnectionParent); > } > > virtual void > + ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy @@ +151,5 @@ > MOZ_COUNT_DTOR(MobileConnectionRequestParent); > } > > virtual void > + ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy ::: dom/mobilemessage/ipc/SmsParent.h @@ +43,5 @@ > MOZ_COUNT_DTOR(SmsParent); > } > > virtual void > + ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy ::: dom/notification/DesktopNotification.h @@ +151,5 @@ > > NS_IMETHODIMP > Observe(nsISupports *aSubject, > const char *aTopic, > + const char16_t *aData) MOZ_OVERRIDE type* aFoo ::: dom/telephony/ipc/TelephonyParent.h @@ +25,5 @@ > protected: > virtual ~TelephonyParent() {} > > virtual void > + ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy @@ +97,5 @@ > TelephonyRequestParent(); > virtual ~TelephonyRequestParent() {} > > virtual void > + ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy
Attachment #8545309 -
Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/238eeecce596
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•