1118831 - Loop: click to add Hello icon to toolbar

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Please add the ability to click to add the Hello icon from the customization palette to the toolbar. This will be used in campaigns for GA 36.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

I won't lie -- I didn't actually test it because it's trivial. :)

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8550556 [details] [diff] [review]
Patch v.1

Review of attachment 8550556 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you add the widgetName and do a manual test.

::: browser/components/uitour/UITour.jsm
@@ +120,5 @@
>        allowAdd: true,
>      }],
> +    ["loop",        {
> +      query: "#loop-button",
> +      allowAdd: true,

I think this isn't enough because you need widgetName so we know which widget to add:
"addNavBarWidget: can't add a widget without a widgetName property"

I didn't test it either though. You should be able to run Mozilla.UITour.addNavBarWidget("loop"); from the Web Console of the Loop tour to test.

BTW. the properties of the objects in the map were sorted alphabetically (other than "forget").

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Added widgetName, made props alphabetical (and fixed the forget button ordering), and did a manual test:

0) New profile, remove Hello button from toolbar.
1) Open https://www.mozilla.org/en-US/firefox/38.0a1/firstrun/
2) In web console, execute:
  Mozilla.UITour.addNavBarWidget("loop", function() { console.log("added") })
3) Button was added to toolbar, callback was invoked.

Comment 4

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/fx-team/rev/1cb7264b9553

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cb7264b9553

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8555495 [details] [diff] [review]
Patch v.2

Approval Request Comment
[Feature/regressing bug #]: Bug 1118874 - Hello tour/snippet/product page for 36
[User impact if declined]: Tour pages cannot help the user add the Hello button to their toolbar.
[Describe test coverage new/current, TreeHerder]: This functionality was tested for the Forget button before.
[Risks and why]: Low risk isolated to UITour. Worst case www.mozilla.org just doesn't use problematic APIs.
[String/UUID change made/needed]: None

RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/220068cf53f9

Comment 8

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b005871a2349