Closed
Bug 1119134
Opened 9 years ago
Closed 9 years ago
[Rocketbar] Tap on a search suggestion should launch the browser and direct the user to the search provider's results
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(Not tracked)
VERIFIED
INVALID
People
(Reporter: hcheng, Unassigned)
References
Details
(Whiteboard: [systemsfe])
*Description: When I tap on a search suggestion in search app, it should launch the browser and direct me to the search provider results. This behavior is defined in page 7 of 2.1 UX spec [1]. *Steps: 1. tap rocketbar to launch search app 2. input "map" and wait until "search suggestions" are shown. 3. tap one of the search suggestions *Expected results: After step 3, search app should launch the browser and direct user to the search provider results. *Actual results: After step 3, search app only changes the input words and the whole results set shown in search app. *Env: Build ID 20150107160220 Gaia Revision d4dac29613076bdba3cb8adc217deadb08a2ac20 Gaia Date 2015-01-07 20:36:48 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/70de2960aa87 Gecko Version 37.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150107.193016 Firmware Date Wed Jan 7 19:30:27 EST 2015 Bootloader L1TC00011880 [1] 2.1 UX spec: https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2099951272/19507117785/1
Reporter | ||
Comment 1•9 years ago
|
||
https://www.youtube.com/watch?v=I6ejfqODj74&feature=youtu.be This problem also exist in v2.1.
blocking-b2g: --- → 2.2?
Flags: needinfo?(bfrancis)
Whiteboard: [systemsfe]
Comment 2•9 years ago
|
||
Hmm, the spec also says that all suggestions should come from EverythingMe (even though a Google icon is displayed next to the suggestions). I don't think an EverythingMe suggestion should take you to a Google search. Francis, am I right in thinking that the currently implemented behaviour is fine for 2.1? In 2.2 the search suggestions should come from the search provider (not EverythingMe) and will open in the browser as described here.
Flags: needinfo?(bfrancis) → needinfo?(fdjabri)
Comment 3•9 years ago
|
||
Hi Ben, You're right - since we reverted to e.me results in 2.1, then tapping on a search suggestion should act as an autocomplete, an in 2.0.
Flags: needinfo?(fdjabri)
Comment 4•9 years ago
|
||
Thanks Francis.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Updated•9 years ago
|
blocking-b2g: 2.2? → ---
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Francis Djabri [:djabber] from comment #3) > Hi Ben, > > You're right - since we reverted to e.me results in 2.1, then tapping on a > search suggestion should act as an autocomplete, an in 2.0. We are going to remove e.me (Bug 111770), so I assume that when Bug 1117770 is resolved, the behavior should become "directing user to browser" but not autocomplete. Is my understanding correct?
Flags: needinfo?(fdjabri)
Comment 6•9 years ago
|
||
Hi Hermes, From my understanding after speaking with @pdol this morning, this e.me suggestions will become replaced with Yahoo suggestions and we still be returning some basic search results. I would say that we shouldn't change the behavior for the reasons Ben mentions - i.e., Yahoo search suggestions shouldn't open up search results for a different search provider in the browser. We should only change this for 2.2. when the search suggestions are coming from the default search provider.
Flags: needinfo?(fdjabri)
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Francis Djabri [:djabber] from comment #6) > Hi Hermes, > > From my understanding after speaking with @pdol this morning, this e.me > suggestions will become replaced with Yahoo suggestions and we still be > returning some basic search results. I would say that we shouldn't change > the behavior for the reasons Ben mentions - i.e., Yahoo search suggestions > shouldn't open up search results for a different search provider in the > browser. We should only change this for 2.2. when the search suggestions are > coming from the default search provider. Hi Francis, thanks. If the changing is only for 2.2, I think this bug should be opened, and block v2.2 bug 1098494. Please correct me if my understanding is wrong.
Reporter | ||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•