1119472 - In-content Preferences, Text color of some text-link is not consistent. And it is difficult to discover them because no underline and low contrast.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

Attachment: screenshot

See attached screenshot.

I notice the problem when I test another Bug 1119441.

Steps to reproduce:
1. in-content preferences

Actual Results:
In-content Preferences, 
Text color of some text-link is not consistent.  
And it is difficult to discover them because no underline and low contrast.

Expected Results:
Text color of some text-link should be consistent. 
It should be easy discoverable (Ex. provide underline or more high-contrast.)

Comment 1

[Alice0775 White]

And hover effect is not consistent

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Looks like we can remove the rules from:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/preferences/preferences.css#89
http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/preferences/preferences.css#93
http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/preferences/preferences.css#191

for .inline-link.

As for the contrast and the underline:
Philipp, are you OK with us adding text-decoration:underline; to all links that share this common.css styling across the browser (http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#392) and also using a darker color (#00539F?) ?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I talked with Stephen over IRC and got the following answers:

We should add the text-decoration:underline on link hover, and use #178ce5 as the darker color.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Looks like we can remove the rules from:

On further note, we shouldn't remove those lines as they were just added in bug 1106792. We should work with those lines or around them.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The presence of the namespace decreased the specificity of the selector to the point where the windowed preferences' styles were overriding.

I never thought a namespace would decrease the specificity. I tested this with the windowed preferences and it doesn't regress there.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8552794 [details] [diff] [review]
Patch

Review of attachment 8552794 [details] [diff] [review]:
-----------------------------------------------------------------

I'll buy that for a dollar. Thanks!

Comment 7

[Carsten Book [:Tomcat]]

renamed 1119472 -> 1119472.patch
applying 1119472.patch
patching file toolkit/themes/shared/in-content/common.inc.css
Hunk #1 FAILED at 382
1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/common.inc.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1119472.patch

jaws: could you take a look at this ? Thanks!

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

This patch was based off of a patch that hadn't landed yet, but has landed now. I just pulled latest and applied this patch and it applied with no failures. Can you please try again?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for checkin

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/3ab0e70121c9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ab0e70121c9

Comment 12

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit and Ubuntu 13.10 32bit using Firefox 38 Beta 6 (buildID: 20150420134330).

I still see the issue on Mac OSX 10.9.5 using Firefox 38 Beta 6 (buildID: 20150420134330): text color of some text-link is not consistent (see "Privacy" tab -> text-link from "History" section). Should I reopen this bug?

Comment 13

[:Gijs (he/him)]

This was fixed on Windows, though, and remains fixed on beta. I'd prefer a new bug for the OSX issue, which is also less severe than the windows issue in the screenshot here.

Comment 14

[Camelia Badau [:cbadau], Desktop QA]

(In reply to :Gijs Kruitbosch (mostly away until May 5th) from comment #13)
> This was fixed on Windows, though, and remains fixed on beta. I'd prefer a
> new bug for the OSX issue, which is also less severe than the windows issue
> in the screenshot here.

I filled bug 1159707 for the OSX issue. 

Marking this bug as VERIFIED FIXED.