1119783 - IonMonkey MIPS: Fix latest build issues (unboxObject)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Branislav Rankov [:rankov]]

Attachment: 1119783-Fix-build.patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8546613 [details] [diff] [review]
1119783-Fix-build.patch

Review of attachment 8546613 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips/MacroAssembler-mips.cpp
@@ +2564,5 @@
>  void
> +MacroAssemblerMIPSCompat::unboxNonDouble(const BaseIndex &src, Register dest)
> +{
> +    computeScaledAddress(src, SecondScratchReg);
> +    ma_lw(dest, Address(SecondScratchReg, PAYLOAD_OFFSET));

We should either use src.offset + PAYLOAD_OFFSET or assert src.offset == 0, right?

Comment 3

[Branislav Rankov [:rankov]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> Comment on attachment 8546613 [details] [diff] [review]
> 1119783-Fix-build.patch
> 
> Review of attachment 8546613 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips/MacroAssembler-mips.cpp
> @@ +2564,5 @@
> >  void
> > +MacroAssemblerMIPSCompat::unboxNonDouble(const BaseIndex &src, Register dest)
> > +{
> > +    computeScaledAddress(src, SecondScratchReg);
> > +    ma_lw(dest, Address(SecondScratchReg, PAYLOAD_OFFSET));
> 
> We should either use src.offset + PAYLOAD_OFFSET or assert src.offset == 0,
> right?

You are right. I will fix this.

Comment 4

[Branislav Rankov [:rankov]]

Attachment: 1119783-Fix-build.patch

Carry review from previous patch.

Comment 5

[Branislav Rankov [:rankov]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f2b89a7f71a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f2b89a7f71a