1119813 - merge remote-troubleshooting version into main generic feedback code

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The remote-troubleshooting stuff is good to go. We need to "land the experiment".

That involves:

1. merging all the generic feedback dev stuff into their appropriate generic feedback counterparts (css, js, html template, view)

2. change the feedbackdev flag from Yes back to No (this should be done on a server-by-server basis)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to work on next week.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tweaking the title, though it's still pretty weird. Making this block bug #1104932 since that's the tracker.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

When doing this, we should clean up the javascript related to putting the browser data in the right place. There's a mild race condition as it stands. Instead of doing what we're doing, we should do all the work when the user clicks on Submit and if it's checked grab the browser data otherwise leave it.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/474

I skipped the stuff in comment #3 and instead created bug #1128693 for it and marked it as mentored.

Still outstanding is changing the flag from yes back to no. I'll do that by hand after I deploy this.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/fjord/commit/16f0a7838ce2cbee18b73b3d06f18c4d1d6f3d04

Will deploy and then change flags from yes to no tomorrow.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed this just now. Changed the "feedbackdev" flag to "Everyone=No" in -stage and -prod environments. Marking as FIXED.