1119852 - Camera width/height constraints ignored on Windows (REGRESSION)

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: undo_d26db5427e8a.patch

STR:
1. On a Windows box with an HD webcam (like Logitech C910 or higher)
2. Open URL
3. Hit [Start!] button and share the camera.

Expected result:
- Success: 1280x720

Actual result:
- Success: 640x480

Tests performed:

Windows 7 FF 32.0:  Success: 1280x720 (good)
Windows 7 FF 34.05: Success: 640x480  (bad)

mozregression only got me so far on my Windows setup:
Last good revision: 0aaa2d3d15cc
First bad revision: 111a1da2a95d

The culprit is https://hg.mozilla.org/integration/mozilla-inbound/rev/d26db5427e8a

I've attached a reverse patch of that commit and verified that it fixes this bug on my Windows 7 machine.

Thanks Florin for catching this in Bug 1094539 comment 17! I'll try to work on some automated tests so this doesn't keep breaking every few months. :-/

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Ugh, let's see if we can fix the bug in that patch because regressing 929431 renders WebRTC (and by extension Loop) unusable for a lot of people.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: fix-requestedcapability

Comment 3

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bb2c1c87b4c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1bb2c1c87b4c

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8547462 [details] [diff] [review]
fix-requestedcapability

Approval Request Comment
[Feature/regressing bug #]: Bug 929431
[User impact if declined]: WebRTC width/height constraints not taken into account on Windows
[Describe test coverage new/current, TBPL]: None, landed on m-c +- week ago
[Risks and why]: Worst case some cameras with bad drivers will be slower starting a WebRTC session or break completely.
[String/UUID change made/needed]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f41efcb45d6
https://hg.mozilla.org/releases/mozilla-beta/rev/ee09df3331d0

Comment 7

[Ada [:adalucinet]]

Reproduced on Nightly 2015-01-09, Windows 7 x64, with str from comment 0 - Success: 640x480 is displayed.
Verified as fixed on 36.0 beta 3 (Build ID: 20150122214638), Aurora 37.0a2 (Build ID: 20150125004007) and Nightly 38.0a1 (Build ID: 20150125030202) with e10s enabled/disabled.