1119962 - "make mochitest-remote" busted on Android with adb > 1.0.29

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

I can run mochitests on an Android device with "make mochitest-remote" via sut, but not via adb. With adb, the browser is never launched. I don't see any activity in logcat. I don't see any errors reported on stdout.

I thought bug 1099475 (quoting url) might be an issue, but reverting that change did not seem to help.

Comment 1

[Bob Clary [:bc] (inactive)]

I think this is probably a dupe of bug 1107906

Comment 2

[Geoff Brown [:gbrown]]

If I substitute "http://mochi.test:8888/tests/?a" for the uri, the browser is launched; if I substitute "http://mochi.test:8888/tests/?a&b", the browser is not launched.

Comment 3

[Bob Clary [:bc] (inactive)]

Geoff, is that the case even with bug 1099475 reverted?

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Bob Clary [:bc:] from comment #3)
> Geoff, is that the case even with bug 1099475 reverted?

Yes. I think the issue may be a change in adb itself. I upgraded my sdk recently.

http://code.google.com/p/android/issues/detail?id=76026

$ adb -version
Android Debug Bridge version 1.0.32

Comment 5

[Geoff Brown [:gbrown]]

"make mochitest-remote" works for me if I both downgrade my sdk and revert bug 1099475.

$ adb -version
Android Debug Bridge version 1.0.29

Either change on its own is ineffective.

Comment 6

[Bob Clary [:bc] (inactive)]

My intentions are to move away from devicemanagerADB and move to adb.py. If you want to revert bug 1099475 and WONTFIX it, I'm ok with that.

Comment 7

[Geoff Brown [:gbrown]]

(In reply to Bob Clary [:bc:] from comment #6)
> My intentions are to move away from devicemanagerADB and move to adb.py. If
> you want to revert bug 1099475 and WONTFIX it, I'm ok with that.

OK, I think that's what I'll do then.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Work around 'adb shell' bustedness in newer Android tools

This seems to work for me, at least. Will push to Try when that's available again.

Comment 9

[Geoff Brown [:gbrown]]

Comment on attachment 8572210 [details] [diff] [review]
Work around 'adb shell' bustedness in newer Android tools

Review of attachment 8572210 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

I tested {"make mochitest-remote" with TEST_PATH=intl/uconv} and {"make mochitest-robocop" with TEST_PATH=testLoad} with adb 1.0.29, 1.0.31, and 1.0.32 -- all worked fine.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9b9157e713c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b9b9157e713c